Commit ad3f78b9 authored Oct 06, 2011 by Kalle Valo

ath6kl: fix null skb dereference in ath6kl_rx()



smatch found that skb might be null in some cases in ath6kl_rx():

ath6kl/txrx.c +1252 ath6kl_rx(222) error: potential null derefence 'skb'.

This will happen when ath6kl is in AP mode and two clients send traffic
to each other.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

parent 2e1cb23c

drivers/net/wireless/ath/ath6kl/txrx.c

+5 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1247,6 +1247,11 @@ void ath6kl_rx(struct htc_target target, struct htc_packet packet)
	}		}
	if (skb1)		if (skb1)
	ath6kl_data_tx(skb1, ar->net_dev);		ath6kl_data_tx(skb1, ar->net_dev);

			if (skb == NULL) {
			/* nothing to deliver up the stack */
			return;
			}
	}		}

	datap = (struct ethhdr *) skb->data;		datap = (struct ethhdr *) skb->data;