Commit acf42175 authored Jun 12, 2006 by Dave Jones Committed by Jens Axboe Jun 23, 2006

[PATCH] remove dead code from elevator switching



We already drop the refcount in elevator_exit(), and as
we're setting 'e' to NULL, we'll never take that branch anyway.
Finally, as 'e' is a local var that isn't referenced afterwards,
setting it to NULL is pointless.

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Jens Axboe <axboe@suse.de>

parent fda151d9

block/elevator.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -850,12 +850,9 @@ static int elevator_switch(request_queue_t q, struct elevator_type new_e)
		* one again (along with re-adding the sysfs dir)
		*/
		elevator_exit(e);
		e = NULL;
		q->elevator = old_elevator;
		elv_register_queue(q);
		clear_bit(QUEUE_FLAG_ELVSWITCH, &q->queue_flags);
		if (e)
		kobject_put(&e->kobj);
		return 0;
		}