Commit ace28a8e authored Apr 16, 2019 by Gustavo A. R. Silva Committed by Greg Kroah-Hartman May 16, 2019

rtlwifi: rtl8723ae: Fix missing break in switch statement



commit 84242b82d81c54e009a2aaa74d3d9eff70babf56 upstream.

Add missing break statement in order to prevent the code from falling
through to case 0x1025, and erroneously setting rtlhal->oem_id to
RT_CID_819X_ACER when rtlefuse->eeprom_svid is equal to 0x10EC and
none of the cases in switch (rtlefuse->eeprom_smid) match.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: 238ad2dd ("rtlwifi: rtl8723ae: Clean up the hardware info routine")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d756d1de

drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1699,6 +1699,7 @@ static void _rtl8723e_read_adapter_info(struct ieee80211_hw *hw,
		rtlhal->oem_id = RT_CID_819X_LENOVO;
		break;
		}
		break;
		case 0x1025:
		rtlhal->oem_id = RT_CID_819X_ACER;
		break;