Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acda146d authored by Mel Gorman's avatar Mel Gorman Committed by Gerrit - the friendly Code Review server
Browse files

mm, compaction: keep cached migration PFNs synced for unusable pageblocks 

Migrate has separate cached PFNs for ASYNC and SYNC* migration on the
basis that some migrations will fail in ASYNC mode.  However, if the
cached PFNs match at the start of scanning and pageblocks are skipped
due to having no isolation candidates, then the sync state does not
matter.  This patch keeps matching cached PFNs in sync until a pageblock
with isolation candidates is found.

The actual benefit is marginal given that the sync scanner following the
async scanner will often skip a number of pageblocks but it's useless
work.  Any benefit depends heavily on whether the scanners restarted
recently.

Change-Id: Ib2e156848785f6783276add839b3f2639f1c9de0
Link: http://lkml.kernel.org/r/20190118175136.31341-16-mgorman@techsingularity.net


Signed-off-by: default avatarMel Gorman <mgorman@techsingularity.net>
Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Rientjes <rientjes@google.com>
Cc: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Git-commit: 8854c55f54bcc104e3adae42abe16948286ec75c
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git


Signed-off-by: default avatarVinayak Menon <vinmenon@codeaurora.org>
parent 27162b40

mm/compaction.c

+18 −0
Original line number Diff line number Diff line
@@ -1971,6 +1971,7 @@ static enum compact_result compact_zone(struct compact_control *cc) 
	unsigned long end_pfn = zone_end_pfn(cc->zone);

	unsigned long last_migrated_pfn;

	const bool sync = cc->mode != MIGRATE_ASYNC;

	bool update_cached;



	cc->migratetype = gfpflags_to_migratetype(cc->gfp_mask);

	ret = compaction_suitable(cc->zone, cc->order, cc->alloc_flags,
@@ -2018,6 +2019,17 @@ static enum compact_result compact_zone(struct compact_control *cc) 


	last_migrated_pfn = 0;



	/*

	 * Migrate has separate cached PFNs for ASYNC and SYNC* migration on

	 * the basis that some migrations will fail in ASYNC mode. However,

	 * if the cached PFNs match and pageblocks are skipped due to having

	 * no isolation candidates, then the sync state does not matter.

	 * Until a pageblock with isolation candidates is found, keep the

	 * cached PFNs in sync to avoid revisiting the same blocks.

	 */

	update_cached = !sync &&

		cc->zone->compact_cached_migrate_pfn[0] == cc->zone->compact_cached_migrate_pfn[1];



	trace_mm_compaction_begin(start_pfn, cc->migrate_pfn,

				cc->free_pfn, end_pfn, sync);
@@ -2049,6 +2061,11 @@ static enum compact_result compact_zone(struct compact_control *cc) 
			last_migrated_pfn = 0;

			goto out;

		case ISOLATE_NONE:

			if (update_cached) {

				cc->zone->compact_cached_migrate_pfn[1] =

					cc->zone->compact_cached_migrate_pfn[0];

			}



			/*

			 * We haven't isolated and migrated anything, but

			 * there might still be unflushed migrations from
@@ -2056,6 +2073,7 @@ static enum compact_result compact_zone(struct compact_control *cc) 
			 */

			goto check_drain;

		case ISOLATE_SUCCESS:

			update_cached = false;

			last_migrated_pfn = start_pfn;

			;

		}