Commit accd5d55 authored Apr 29, 2023 by Shay Drory Committed by Greg Kroah-Hartman Jun 09, 2023

net/mlx5: fw_tracer, Fix event handling



[ Upstream commit 341a80de2468f481b1f771683709b5649cbfe513 ]

mlx5 driver needs to parse traces with event_id inside the range of
first_string_trace and num_string_trace. However, mlx5 is parsing all
events with event_id >= first_string_trace.

Fix it by checking for the correct range.

Fixes: c71ad41c ("net/mlx5: FW tracer, events handling")
Signed-off-by: Shay Drory <shayd@nvidia.com>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent cdafe0cc

drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -466,7 +466,7 @@ static void poll_trace(struct mlx5_fw_tracer *tracer,
		(u64)timestamp_low;
		break;
		default:
		if (tracer_event->event_id >= tracer->str_db.first_string_trace \|\|
		if (tracer_event->event_id >= tracer->str_db.first_string_trace &&
		tracer_event->event_id <= tracer->str_db.first_string_trace +
		tracer->str_db.num_string_trace) {
		tracer_event->type = TRACER_EVENT_TYPE_STRING;