Commit acb4b7df authored Jun 28, 2017 by Dan Carpenter Committed by David S. Miller Jun 29, 2017

rocker: move dereference before free



My static checker complains that ofdpa_neigh_del() can sometimes free
"found".   It just makes sense to use it first before deleting it.

Fixes: ecf244f7 ("rocker: fix maybe-uninitialized warning")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6b27c8ad

drivers/net/ethernet/rocker/rocker_ofdpa.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1505,8 +1505,8 @@ static int ofdpa_port_ipv4_nh(struct ofdpa_port *ofdpa_port,
		*index = entry->index;
		resolved = false;
		} else if (removing) {
		ofdpa_neigh_del(trans, found);
		*index = found->index;
		ofdpa_neigh_del(trans, found);
		} else if (updating) {
		ofdpa_neigh_update(found, trans, NULL, false);
		resolved = !is_zero_ether_addr(found->eth_dst);