Commit ac8e28a9 authored Dec 23, 2019 by Zong Li Committed by Greg Kroah-Hartman Jan 09, 2020

riscv: ftrace: correct the condition logic in function graph tracer



commit 1d8f65798240b6577d8c44d20c8ea8f1d429e495 upstream.

The condition should be logical NOT to assign the hook address to parent
address. Because the return value 0 of function_graph_enter upon
success.

Fixes: e949b6db51dc (riscv/function_graph: Simplify with function_graph_enter())
Signed-off-by: Zong Li <zong.li@sifive.com>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: stable@vger.kernel.org
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 316a9a84

arch/riscv/kernel/ftrace.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -142,7 +142,7 @@ void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr,
		*/
		old = *parent;

		if (function_graph_enter(old, self_addr, frame_pointer, parent))
		if (!function_graph_enter(old, self_addr, frame_pointer, parent))
		*parent = return_hooker;
		}