Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac85dfa4 authored by Daniil Dulov's avatar Daniil Dulov Committed by Greg Kroah-Hartman
Browse files

media: dib7000p: Fix potential division by zero 



[ Upstream commit a1db7b2c5533fc67e2681eb5efc921a67bc7d5b8 ]

Variable loopdiv can be assigned 0, then it is used as a denominator,
without checking it for 0.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 713d54a8 ("[media] DiB7090: add support for the dib7090 based")
Signed-off-by: default avatarDaniil Dulov <d.dulov@aladdin.ru>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
[hverkuil: (bw != NULL) -> bw]
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e483536a

drivers/media/dvb-frontends/dib7000p.c

+1 −1
Original line number Diff line number Diff line
@@ -500,7 +500,7 @@ static int dib7000p_update_pll(struct dvb_frontend *fe, struct dibx000_bandwidth 
	prediv = reg_1856 & 0x3f;

	loopdiv = (reg_1856 >> 6) & 0x3f;



	if ((bw != NULL) && (bw->pll_prediv != prediv || bw->pll_ratio != loopdiv)) {

	if (loopdiv && bw && (bw->pll_prediv != prediv || bw->pll_ratio != loopdiv)) {

		dprintk("Updating pll (prediv: old =  %d new = %d ; loopdiv : old = %d new = %d)\n", prediv, bw->pll_prediv, loopdiv, bw->pll_ratio);

		reg_1856 &= 0xf000;

		reg_1857 = dib7000p_read_word(state, 1857);