Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab925a31 authored by Shawn Lin's avatar Shawn Lin Committed by Ulf Hansson
Browse files

mmc: dw_mmc: avoid using dmaengine_terminate_all 



dmaengine_terminate_all is deprecated and should be
replaced by more explicit synchronous and asynchronous
terminate functions. This change is based on the
commit b36f09c3 ("dmaengine: Add transfer termination
synchronization support"). Currently dw_mci_stop_dma
may be called under the spinlock, let's migrate
dmaengine_terminate_all to async terminate. This could
avoid the race condition of use-after-free resouce of
dmaengine once slave-dma driver implement the synchronize
method.

Signed-off-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: default avatarJaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 49b17858

drivers/mmc/host/dw_mmc.c

+1 −1
Original line number Diff line number Diff line
@@ -680,7 +680,7 @@ static const struct dw_mci_dma_ops dw_mci_idmac_ops = { 


static void dw_mci_edmac_stop_dma(struct dw_mci *host)

{

	dmaengine_terminate_all(host->dms->ch);

	dmaengine_terminate_async(host->dms->ch);

}



static int dw_mci_edmac_start_dma(struct dw_mci *host,