Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab72002b authored by Moger, Babu's avatar Moger, Babu Committed by James Bottomley
Browse files

[SCSI] scsi_dh_alua: Fix the time inteval for alua rtpg commands 



This patch corrects the retry interval for alua rtpg command. Purpose was to retry the commands in seconds.
But that was not happening. Reason is msleep takes argument in milliseconds.

Also added minor text after successful attach.

Signed-off-by: default avatarBabu Moger <babu.moger@netapp.com>
Acked-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent eae627e4

drivers/scsi/device_handler/scsi_dh_alua.c

+2 −1
Original line number Diff line number Diff line
@@ -507,7 +507,7 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_dh_data *h) 
	int len, k, off, valid_states = 0;

	unsigned char *ucp;

	unsigned err;

	unsigned long expiry, interval = 1;

	unsigned long expiry, interval = 1000;



	expiry = round_jiffies_up(jiffies + ALUA_FAILOVER_TIMEOUT);

 retry:
@@ -734,6 +734,7 @@ static int alua_bus_attach(struct scsi_device *sdev) 
	spin_lock_irqsave(sdev->request_queue->queue_lock, flags);

	sdev->scsi_dh_data = scsi_dh_data;

	spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);

	sdev_printk(KERN_NOTICE, sdev, "%s: Attached\n", ALUA_DH_NAME);



	return 0;