Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab02165c authored by Aviya Erenfeld's avatar Aviya Erenfeld Committed by Emmanuel Grumbach
Browse files

iwlwifi: add wide firmware command infrastructure for TX 



As the firmware is slowly running out of command IDs and grouping of
commands is desirable anyway, the firmware is extending the command
header from 4 bytes to 8 bytes to introduce a group (in place of the
former flags field, since that's always 0 on commands and thus can
be easily used to distinguish between the two.

In order to support this most easily in the driver widen the command
command ID used in the command sending functions and encode the new
values (group and version) in the ID. That way existing code doesn't
have to be changed (since the higher bits are 0 automatically) and
newer code can easily use the new ID generation function to create a
value to use in place of just the command ID.

Signed-off-by: default avatarAviya Erenfeld <aviya.erenfeld@intel.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent ce792918

drivers/net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h

+9 −5
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ 
TRACE_EVENT(iwlwifi_dev_hcmd,

	TP_PROTO(const struct device *dev,

		 struct iwl_host_cmd *cmd, u16 total_size,

		 struct iwl_cmd_header *hdr),

		 struct iwl_cmd_header_wide *hdr),

	TP_ARGS(dev, cmd, total_size, hdr),

	TP_STRUCT__entry(

		DEV_ENTRY
@@ -44,11 +44,14 @@ TRACE_EVENT(iwlwifi_dev_hcmd, 
		__field(u32, flags)

	),

	TP_fast_assign(

		int i, offset = sizeof(*hdr);

		int i, offset = sizeof(struct iwl_cmd_header);



		if (hdr->group_id)

			offset = sizeof(struct iwl_cmd_header_wide);



		DEV_ASSIGN;

		__entry->flags = cmd->flags;

		memcpy(__get_dynamic_array(hcmd), hdr, sizeof(*hdr));

		memcpy(__get_dynamic_array(hcmd), hdr, offset);



		for (i = 0; i < IWL_MAX_CMD_TBS_PER_TFD; i++) {

			if (!cmd->len[i])
@@ -58,8 +61,9 @@ TRACE_EVENT(iwlwifi_dev_hcmd, 
			offset += cmd->len[i];

		}

	),

	TP_printk("[%s] hcmd %#.2x (%ssync)",

		  __get_str(dev), ((u8 *)__get_dynamic_array(hcmd))[0],

	TP_printk("[%s] hcmd %#.2x.%#.2x (%ssync)",

		  __get_str(dev), ((u8 *)__get_dynamic_array(hcmd))[1],

		  ((u8 *)__get_dynamic_array(hcmd))[0],

		  __entry->flags & CMD_ASYNC ? "a" : "")

);

drivers/net/wireless/iwlwifi/iwl-fw-file.h

+2 −0
Original line number Diff line number Diff line
@@ -247,6 +247,7 @@ typedef unsigned int __bitwise__ iwl_ucode_tlv_api_t; 
 * @IWL_UCODE_TLV_API_WIFI_MCC_UPDATE: ucode supports MCC updates with source.

 * IWL_UCODE_TLV_API_HDC_PHASE_0: ucode supports finer configuration of LTR

 * @IWL_UCODE_TLV_API_TX_POWER_DEV: new API for tx power.

 * @IWL_UCODE_TLV_API_WIDE_CMD_HDR: ucode supports wide command header

 * @IWL_UCODE_TLV_API_SCD_CFG: This firmware can configure the scheduler

 *	through the dedicated host command.

 * @IWL_UCODE_TLV_API_SINGLE_SCAN_EBS: EBS is supported for single scans too.
@@ -263,6 +264,7 @@ enum iwl_ucode_tlv_api { 
	IWL_UCODE_TLV_API_WIFI_MCC_UPDATE	= (__force iwl_ucode_tlv_api_t)9,

	IWL_UCODE_TLV_API_HDC_PHASE_0		= (__force iwl_ucode_tlv_api_t)10,

	IWL_UCODE_TLV_API_TX_POWER_DEV		= (__force iwl_ucode_tlv_api_t)11,

	IWL_UCODE_TLV_API_WIDE_CMD_HDR		= (__force iwl_ucode_tlv_api_t)14,

	IWL_UCODE_TLV_API_SCD_CFG		= (__force iwl_ucode_tlv_api_t)15,

	IWL_UCODE_TLV_API_SINGLE_SCAN_EBS	= (__force iwl_ucode_tlv_api_t)16,

	IWL_UCODE_TLV_API_ASYNC_DTM		= (__force iwl_ucode_tlv_api_t)17,

drivers/net/wireless/iwlwifi/iwl-trans.h

+61 −5
Original line number Diff line number Diff line
@@ -122,6 +122,32 @@ 
#define INDEX_TO_SEQ(i)	((i) & 0xff)

#define SEQ_RX_FRAME	cpu_to_le16(0x8000)



/*

 * those functions retrieve specific information from

 * the id field in the iwl_host_cmd struct which contains

 * the command id, the group id and the version of the command

 * and vice versa

*/

static inline u8 iwl_cmd_opcode(u32 cmdid)

{

	return cmdid & 0xFF;

}



static inline u8 iwl_cmd_groupid(u32 cmdid)

{

	return ((cmdid & 0xFF00) >> 8);

}



static inline u8 iwl_cmd_version(u32 cmdid)

{

	return ((cmdid & 0xFF0000) >> 16);

}



static inline u32 iwl_cmd_id(u8 opcode, u8 groupid, u8 version)

{

	return opcode + (groupid << 8) + (version << 16);

}



/**

 * struct iwl_cmd_header

 *
@@ -130,7 +156,7 @@ 
 */

struct iwl_cmd_header {

	u8 cmd;		/* Command ID:  REPLY_RXON, etc. */

	u8 reserved;

	u8 group_id;

	/*

	 * The driver sets up the sequence number to values of its choosing.

	 * uCode does not use this value, but passes it back to the driver
@@ -154,6 +180,23 @@ struct iwl_cmd_header { 
	__le16 sequence;

} __packed;



/**

 * struct iwl_cmd_header_wide

 *

 * This header format appears in the beginning of each command sent from the

 * driver, and each response/notification received from uCode.

 * this is the wide version that contains more information about the command

 * like length, version and command type

 */

struct iwl_cmd_header_wide {

	u8 cmd;

	u8 group_id;

	__le16 sequence;

	__le16 length;

	u8 reserved;

	u8 version;

} __packed;



#define FH_RSCSR_FRAME_SIZE_MSK		0x00003FFF	/* bits 0-13 */

#define FH_RSCSR_FRAME_INVALID		0x55550000

#define FH_RSCSR_FRAME_ALIGN		0x40
@@ -218,8 +261,18 @@ enum CMD_MODE { 
 * aren't fully copied and use other TFD space.

 */

struct iwl_device_cmd {

	union {

		struct {

			struct iwl_cmd_header hdr;	/* uCode API */

			u8 payload[DEF_CMD_PAYLOAD_SIZE];

		};

		struct {

			struct iwl_cmd_header_wide hdr_wide;

			u8 payload_wide[DEF_CMD_PAYLOAD_SIZE -

					sizeof(struct iwl_cmd_header_wide) +

					sizeof(struct iwl_cmd_header)];

		};

	};

} __packed;



#define TFD_MAX_PAYLOAD_SIZE (sizeof(struct iwl_device_cmd))
@@ -260,7 +313,8 @@ enum iwl_hcmd_dataflag { 
 * @flags: can be CMD_*

 * @len: array of the lengths of the chunks in data

 * @dataflags: IWL_HCMD_DFL_*

 * @id: id of the host command

 * @id: command id of the host command, for wide commands encoding the

 *	version and group as well

 */

struct iwl_host_cmd {

	const void *data[IWL_MAX_CMD_TBS_PER_TFD];
@@ -269,9 +323,9 @@ struct iwl_host_cmd { 
	u32 _rx_page_order;



	u32 flags;

	u32 id;

	u16 len[IWL_MAX_CMD_TBS_PER_TFD];

	u8 dataflags[IWL_MAX_CMD_TBS_PER_TFD];

	u8 id;

};



static inline void iwl_free_resp(struct iwl_host_cmd *cmd)
@@ -372,6 +426,7 @@ enum iwl_trans_status { 
 * @bc_table_dword: set to true if the BC table expects the byte count to be

 *	in DWORD (as opposed to bytes)

 * @scd_set_active: should the transport configure the SCD for HCMD queue

 * @wide_cmd_header: firmware supports wide host command header

 * @command_names: array of command names, must be 256 entries

 *	(one for each command); for debugging only

 * @sdio_adma_addr: the default address to set for the ADMA in SDIO mode until
@@ -389,6 +444,7 @@ struct iwl_trans_config { 
	bool rx_buf_size_8k;

	bool bc_table_dword;

	bool scd_set_active;

	bool wide_cmd_header;

	const char *const *command_names;



	u32 sdio_adma_addr;

drivers/net/wireless/iwlwifi/mvm/mvm.h

+2 −2
Original line number Diff line number Diff line
@@ -977,12 +977,12 @@ u8 iwl_mvm_next_antenna(struct iwl_mvm *mvm, u8 valid, u8 last_idx); 
/* Tx / Host Commands */

int __must_check iwl_mvm_send_cmd(struct iwl_mvm *mvm,

				  struct iwl_host_cmd *cmd);

int __must_check iwl_mvm_send_cmd_pdu(struct iwl_mvm *mvm, u8 id,

int __must_check iwl_mvm_send_cmd_pdu(struct iwl_mvm *mvm, u32 id,

				      u32 flags, u16 len, const void *data);

int __must_check iwl_mvm_send_cmd_status(struct iwl_mvm *mvm,

					 struct iwl_host_cmd *cmd,

					 u32 *status);

int __must_check iwl_mvm_send_cmd_pdu_status(struct iwl_mvm *mvm, u8 id,

int __must_check iwl_mvm_send_cmd_pdu_status(struct iwl_mvm *mvm, u32 id,

					     u16 len, const void *data,

					     u32 *status);

int iwl_mvm_tx_skb(struct iwl_mvm *mvm, struct sk_buff *skb,

drivers/net/wireless/iwlwifi/mvm/ops.c

+2 −0
Original line number Diff line number Diff line
@@ -469,6 +469,8 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg, 
	trans_cfg.no_reclaim_cmds = no_reclaim_cmds;

	trans_cfg.n_no_reclaim_cmds = ARRAY_SIZE(no_reclaim_cmds);

	trans_cfg.rx_buf_size_8k = iwlwifi_mod_params.amsdu_size_8K;

	trans_cfg.wide_cmd_header = fw_has_api(&mvm->fw->ucode_capa,

					       IWL_UCODE_TLV_API_WIDE_CMD_HDR);



	if (mvm->fw->ucode_capa.flags & IWL_UCODE_TLV_FLAGS_DW_BC_TABLE)

		trans_cfg.bc_table_dword = true;