Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aaeecd80 authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Jonathan Cameron
Browse files

iio: accel: bmc150: Error handling when mode set fails 



When mode set fails due to some transient failures, it will atleast
reset the state of runtime usage count and also let the runtime
suspend retry from the driver framework.

Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 6896ab3a

drivers/iio/accel/bmc150-accel.c

+10 −1
Original line number Diff line number Diff line
@@ -536,6 +536,9 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on) 
	if (ret < 0) {

		dev_err(&data->client->dev,

			"Failed: bmc150_accel_set_power_state for %d\n", on);

		if (on)

			pm_runtime_put_noidle(&data->client->dev);



		return ret;

	}
@@ -811,6 +814,7 @@ static int bmc150_accel_write_event_config(struct iio_dev *indio_dev, 


	ret =  bmc150_accel_setup_any_motion_interrupt(data, state);

	if (ret < 0) {

		bmc150_accel_set_power_state(data, false);

		mutex_unlock(&data->mutex);

		return ret;

	}
@@ -1054,6 +1058,7 @@ static int bmc150_accel_data_rdy_trigger_set_state(struct iio_trigger *trig, 
	else

		ret = bmc150_accel_setup_new_data_interrupt(data, state);

	if (ret < 0) {

		bmc150_accel_set_power_state(data, false);

		mutex_unlock(&data->mutex);

		return ret;

	}
@@ -1354,10 +1359,14 @@ static int bmc150_accel_runtime_suspend(struct device *dev) 
{

	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));

	struct bmc150_accel_data *data = iio_priv(indio_dev);

	int ret;



	dev_dbg(&data->client->dev,  __func__);

	ret = bmc150_accel_set_mode(data, BMC150_ACCEL_SLEEP_MODE_SUSPEND, 0);

	if (ret < 0)

		return -EAGAIN;



	return bmc150_accel_set_mode(data, BMC150_ACCEL_SLEEP_MODE_SUSPEND, 0);

	return 0;

}



static int bmc150_accel_runtime_resume(struct device *dev)