Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aaad2d8c authored by Ben Goz's avatar Ben Goz Committed by Oded Gabbay
Browse files

drm/amdkfd: destroy mqd when destroying kernel queue 



This patch adds a missing destruction of mqd, when destroying a kernel queue.
Without the destruction, there is a memory leakage when repeatedly creating and
destroying kernel queues.

Signed-off-by: default avatarBen Goz <ben.goz@amd.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
parent 06e5801b

drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c

+13 −9
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ static bool initialize(struct kernel_queue *kq, struct kfd_dev *dev, 
	BUG_ON(!kq || !dev);

	BUG_ON(type != KFD_QUEUE_TYPE_DIQ && type != KFD_QUEUE_TYPE_HIQ);



	pr_debug("kfd: In func %s initializing queue type %d size %d\n",

	pr_debug("amdkfd: In func %s initializing queue type %d size %d\n",

			__func__, KFD_QUEUE_TYPE_HIQ, queue_size);



	nop.opcode = IT_NOP;
@@ -69,12 +69,16 @@ static bool initialize(struct kernel_queue *kq, struct kfd_dev *dev, 


	prop.doorbell_ptr = kfd_get_kernel_doorbell(dev, &prop.doorbell_off);



	if (prop.doorbell_ptr == NULL)

	if (prop.doorbell_ptr == NULL) {

		pr_err("amdkfd: error init doorbell");

		goto err_get_kernel_doorbell;

	}



	retval = kfd_gtt_sa_allocate(dev, queue_size, &kq->pq);

	if (retval != 0)

	if (retval != 0) {

		pr_err("amdkfd: error init pq queues size (%d)\n", queue_size);

		goto err_pq_allocate_vidmem;

	}



	kq->pq_kernel_addr = kq->pq->cpu_ptr;

	kq->pq_gpu_addr = kq->pq->gpu_addr;
@@ -165,10 +169,8 @@ static bool initialize(struct kernel_queue *kq, struct kfd_dev *dev, 
err_eop_allocate_vidmem:

	kfd_gtt_sa_free(dev, kq->pq);

err_pq_allocate_vidmem:

	pr_err("kfd: error init pq\n");

	kfd_release_kernel_doorbell(dev, prop.doorbell_ptr);

err_get_kernel_doorbell:

	pr_err("kfd: error init doorbell");

	return false;



}
@@ -187,6 +189,8 @@ static void uninitialize(struct kernel_queue *kq) 
	else if (kq->queue->properties.type == KFD_QUEUE_TYPE_DIQ)

		kfd_gtt_sa_free(kq->dev, kq->fence_mem_obj);



	kq->mqd->uninit_mqd(kq->mqd, kq->queue->mqd, kq->queue->mqd_mem_obj);



	kfd_gtt_sa_free(kq->dev, kq->rptr_mem);

	kfd_gtt_sa_free(kq->dev, kq->wptr_mem);

	kq->ops_asic_specific.uninitialize(kq);
@@ -211,7 +215,7 @@ static int acquire_packet_buffer(struct kernel_queue *kq, 
	queue_address = (unsigned int *)kq->pq_kernel_addr;

	queue_size_dwords = kq->queue->properties.queue_size / sizeof(uint32_t);



	pr_debug("kfd: In func %s\nrptr: %d\nwptr: %d\nqueue_address 0x%p\n",

	pr_debug("amdkfd: In func %s\nrptr: %d\nwptr: %d\nqueue_address 0x%p\n",

			__func__, rptr, wptr, queue_address);



	available_size = (rptr - 1 - wptr + queue_size_dwords) %
@@ -296,7 +300,7 @@ struct kernel_queue *kernel_queue_init(struct kfd_dev *dev, 
	}



	if (kq->ops.initialize(kq, dev, type, KFD_KERNEL_QUEUE_SIZE) == false) {

		pr_err("kfd: failed to init kernel queue\n");

		pr_err("amdkfd: failed to init kernel queue\n");

		kfree(kq);

		return NULL;

	}
@@ -319,7 +323,7 @@ static __attribute__((unused)) void test_kq(struct kfd_dev *dev) 


	BUG_ON(!dev);



	pr_err("kfd: starting kernel queue test\n");

	pr_err("amdkfd: starting kernel queue test\n");



	kq = kernel_queue_init(dev, KFD_QUEUE_TYPE_HIQ);

	BUG_ON(!kq);
@@ -330,7 +334,7 @@ static __attribute__((unused)) void test_kq(struct kfd_dev *dev) 
		buffer[i] = kq->nop_packet;

	kq->ops.submit_packet(kq);



	pr_err("kfd: ending kernel queue test\n");

	pr_err("amdkfd: ending kernel queue test\n");

}