Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa73a3b2 authored by Pi-Hsun Shih's avatar Pi-Hsun Shih Committed by Greg Kroah-Hartman
Browse files

pstore: Set tfm to NULL on free_buf_for_compression 



commit a9fb94a99bb515d8720ba8440ce3aba84aec80f8 upstream.

Set tfm to NULL on free_buf_for_compression() after crypto_free_comp().

This avoid a use-after-free when allocate_buf_for_compression()
and free_buf_for_compression() are called twice. Although
free_buf_for_compression() freed the tfm, allocate_buf_for_compression()
won't reinitialize the tfm since the tfm pointer is not NULL.

Fixes: 95047b0519c1 ("pstore: Refactor compression initialization")
Signed-off-by: default avatarPi-Hsun Shih <pihsun@chromium.org>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d4128a1b

fs/pstore/platform.c

+3 −1
Original line number Diff line number Diff line
@@ -324,8 +324,10 @@ static void allocate_buf_for_compression(void) 


static void free_buf_for_compression(void)

{

	if (IS_ENABLED(CONFIG_PSTORE_COMPRESS) && tfm)

	if (IS_ENABLED(CONFIG_PSTORE_COMPRESS) && tfm) {

		crypto_free_comp(tfm);

		tfm = NULL;

	}

	kfree(big_oops_buf);

	big_oops_buf = NULL;

	big_oops_buf_sz = 0;