Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa4ad88c authored by Mintz, Yuval's avatar Mintz, Yuval Committed by David S. Miller
Browse files

qed: Fix uninitialized data in aRFS infrastructure 



Current memset is using incorrect type of variable, causing the
upper-half of the strucutre to be left uninitialized and causing:

  ethernet/qlogic/qed/qed_init_fw_funcs.c: In function 'qed_set_rfs_mode_disable':
  ethernet/qlogic/qed/qed_init_fw_funcs.c:993:3: error: '*((void *)&ramline+4)' is used uninitialized in this function [-Werror=uninitialized]

Fixes: d51e4af5 ("qed: aRFS infrastructure support")
Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@cavium.com>
Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8c977f5a

drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c

+1 −1
Original line number Diff line number Diff line
@@ -983,7 +983,7 @@ void qed_set_rfs_mode_disable(struct qed_hwfn *p_hwfn, 
	memset(&camline, 0, sizeof(union gft_cam_line_union));

	qed_wr(p_hwfn, p_ptt, PRS_REG_GFT_CAM + CAM_LINE_SIZE * pf_id,

	       camline.cam_line_mapped.camline);

	memset(&ramline, 0, sizeof(union gft_cam_line_union));

	memset(&ramline, 0, sizeof(ramline));



	for (i = 0; i < RAM_LINE_SIZE / REG_SIZE; i++) {

		u32 hw_addr = PRS_REG_GFT_PROFILE_MASK_RAM;