Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa090eab authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: target: Remove second argument from fabric_make_tpg() 



Since most target drivers do not use the second fabric_make_tpg() argument
("group") and since it is trivial to derive the group pointer from the wwn
pointer, do not pass the group pointer to fabric_make_tpg().

Signed-off-by: default avatarBart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: default avatarMike Christie <mchristi@redhat.com>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 35bea5c8

drivers/infiniband/ulp/srpt/ib_srpt.c

+0 −2
Original line number Diff line number Diff line
@@ -3597,11 +3597,9 @@ static struct configfs_attribute *srpt_tpg_attrs[] = { 
/**

 * srpt_make_tpg - configfs callback invoked for mkdir /sys/kernel/config/target/$driver/$port/$tpg

 * @wwn: Corresponds to $driver/$port.

 * @group: Not used.

 * @name: $tpg.

 */

static struct se_portal_group *srpt_make_tpg(struct se_wwn *wwn,

					     struct config_group *group,

					     const char *name)

{

	struct srpt_port *sport = wwn->priv;

drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c

+0 −1
Original line number Diff line number Diff line
@@ -3928,7 +3928,6 @@ static void ibmvscsis_drop_tport(struct se_wwn *wwn) 
}



static struct se_portal_group *ibmvscsis_make_tpg(struct se_wwn *wwn,

						  struct config_group *group,

						  const char *name)

{

	struct ibmvscsis_tport *tport =

drivers/scsi/qla2xxx/tcm_qla2xxx.c

+4 −8
Original line number Diff line number Diff line
@@ -1049,9 +1049,7 @@ static struct configfs_attribute *tcm_qla2xxx_tpg_attrs[] = { 
	NULL,

};



static struct se_portal_group *tcm_qla2xxx_make_tpg(

	struct se_wwn *wwn,

	struct config_group *group,

static struct se_portal_group *tcm_qla2xxx_make_tpg(struct se_wwn *wwn,

						    const char *name)

{

	struct tcm_qla2xxx_lport *lport = container_of(wwn,
@@ -1171,9 +1169,7 @@ static struct configfs_attribute *tcm_qla2xxx_npiv_tpg_attrs[] = { 
        NULL,

};



static struct se_portal_group *tcm_qla2xxx_npiv_make_tpg(

	struct se_wwn *wwn,

	struct config_group *group,

static struct se_portal_group *tcm_qla2xxx_npiv_make_tpg(struct se_wwn *wwn,

							 const char *name)

{

	struct tcm_qla2xxx_lport *lport = container_of(wwn,

drivers/target/iscsi/iscsi_target_configfs.c

+2 −4
Original line number Diff line number Diff line
@@ -1090,9 +1090,7 @@ static struct configfs_attribute *lio_target_tpg_attrs[] = { 


/* Start items for lio_target_tiqn_cit */



static struct se_portal_group *lio_target_tiqn_addtpg(

	struct se_wwn *wwn,

	struct config_group *group,

static struct se_portal_group *lio_target_tiqn_addtpg(struct se_wwn *wwn,

						      const char *name)

{

	struct iscsi_portal_group *tpg;

drivers/target/loopback/tcm_loop.c

+2 −4
Original line number Diff line number Diff line
@@ -983,9 +983,7 @@ static struct configfs_attribute *tcm_loop_tpg_attrs[] = { 


/* Start items for tcm_loop_naa_cit */



static struct se_portal_group *tcm_loop_make_naa_tpg(

	struct se_wwn *wwn,

	struct config_group *group,

static struct se_portal_group *tcm_loop_make_naa_tpg(struct se_wwn *wwn,

						     const char *name)

{

	struct tcm_loop_hba *tl_hba = container_of(wwn,