Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9fbc3b7 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Sumit Semwal
Browse files

dma-buf: Return error instead of using a goto statement when possible 



Remove an error label in dma_buf_attach() that just returns an error
code.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarSumit Semwal <sumit.semwal@linaro.org>
parent d1aa06a1

drivers/base/dma-buf.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -190,7 +190,7 @@ struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf, 




	attach = kzalloc(sizeof(struct dma_buf_attachment), GFP_KERNEL);

	attach = kzalloc(sizeof(struct dma_buf_attachment), GFP_KERNEL);

	if (attach == NULL)

	if (attach == NULL)

		goto err_alloc;

		return ERR_PTR(-ENOMEM);





	mutex_lock(&dmabuf->lock);

	mutex_lock(&dmabuf->lock);
@@ -206,8 +206,6 @@ struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf, 
	mutex_unlock(&dmabuf->lock);

	mutex_unlock(&dmabuf->lock);

	return attach;

	return attach;





err_alloc:

	return ERR_PTR(-ENOMEM);

err_attach:

err_attach:

	kfree(attach);

	kfree(attach);

	mutex_unlock(&dmabuf->lock);

	mutex_unlock(&dmabuf->lock);