Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9e64931 authored by Tvrtko Ursulin's avatar Tvrtko Ursulin
Browse files

drm/i915: No need to save/restore irq status in intel_breadcrumbs_fake_irq 



Timer callback is a known context so it is correct to always
disable interrupts.

Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent 2c33b541

drivers/gpu/drm/i915/intel_breadcrumbs.c

+2 −3
Original line number Diff line number Diff line
@@ -109,7 +109,6 @@ static void intel_breadcrumbs_fake_irq(unsigned long data) 
{

	struct intel_engine_cs *engine = (struct intel_engine_cs *)data;

	struct intel_breadcrumbs *b = &engine->breadcrumbs;

	unsigned long flags;



	/*

	 * The timer persists in case we cannot enable interrupts,
@@ -119,10 +118,10 @@ static void intel_breadcrumbs_fake_irq(unsigned long data) 
	 * coherent seqno check.

	 */



	spin_lock_irqsave(&b->irq_lock, flags);

	spin_lock_irq(&b->irq_lock);

	if (!__intel_breadcrumbs_wakeup(b))

		__intel_engine_disarm_breadcrumbs(engine);

	spin_unlock_irqrestore(&b->irq_lock, flags);

	spin_unlock_irq(&b->irq_lock);

	if (!b->irq_armed)

		return;