Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9a19989 authored by Anant Thazhemadam's avatar Anant Thazhemadam Committed by Greg Kroah-Hartman
Browse files

staging: comedi: check validity of wMaxPacketSize of usb endpoints found 



commit e1f13c879a7c21bd207dc6242455e8e3a1e88b40 upstream.

While finding usb endpoints in vmk80xx_find_usb_endpoints(), check if
wMaxPacketSize = 0 for the endpoints found.

Some devices have isochronous endpoints that have wMaxPacketSize = 0
(as required by the USB-2 spec).
However, since this doesn't apply here, wMaxPacketSize = 0 can be
considered to be invalid.

Reported-by: default avatar <syzbot+009f546aa1370056b1c2@syzkaller.appspotmail.com>
Tested-by: default avatar <syzbot+009f546aa1370056b1c2@syzkaller.appspotmail.com>
Signed-off-by: default avatarAnant Thazhemadam <anant.thazhemadam@gmail.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20201010082933.5417-1-anant.thazhemadam@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aa803a62

drivers/staging/comedi/drivers/vmk80xx.c

+3 −0
Original line number Diff line number Diff line
@@ -667,6 +667,9 @@ static int vmk80xx_find_usb_endpoints(struct comedi_device *dev) 
	if (!devpriv->ep_rx || !devpriv->ep_tx)

		return -ENODEV;



	if (!usb_endpoint_maxp(devpriv->ep_rx) || !usb_endpoint_maxp(devpriv->ep_tx))

		return -EINVAL;



	return 0;

}