Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a970d8db authored by Tariq Toukan's avatar Tariq Toukan Committed by David S. Miller
Browse files

net/mlx4_en: RX csum, pre-define enabled protocols for IP status masking 



Pre-define a mask for IP status of a completion, that tests the
MLX4_CQE_STATUS_IPV6 only in case CONFIG_IPV6 is enabled.
Use it for IP status testing upon completion, instead of separating
the datapath into two flows.
This takes common code structures (such as closing parenthesis)
back to their original place, and makes code more readable.

Signed-off-by: default avatarTariq Toukan <tariqt@mellanox.com>
Suggested-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1cb8b121

drivers/net/ethernet/mellanox/mlx4/en_rx.c

+7 −6
Original line number Diff line number Diff line
@@ -649,6 +649,12 @@ static int check_csum(struct mlx4_cqe *cqe, struct sk_buff *skb, void *va, 
	return get_fixed_ipv4_csum(hw_checksum, skb, hdr);

}



#if IS_ENABLED(CONFIG_IPV6)

#define MLX4_CQE_STATUS_IP_ANY (MLX4_CQE_STATUS_IPV4 | MLX4_CQE_STATUS_IPV6)

#else

#define MLX4_CQE_STATUS_IP_ANY (MLX4_CQE_STATUS_IPV4)

#endif



int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int budget)

{

	struct mlx4_en_priv *priv = netdev_priv(dev);
@@ -835,12 +841,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud 
				ring->csum_ok++;

			} else {

				if (!(priv->flags & MLX4_EN_FLAG_RX_CSUM_NON_TCP_UDP &&

				      (cqe->status & cpu_to_be16(MLX4_CQE_STATUS_IPV4 |

#if IS_ENABLED(CONFIG_IPV6)

								 MLX4_CQE_STATUS_IPV6))))

#else

								 0))))

#endif

				      (cqe->status & cpu_to_be16(MLX4_CQE_STATUS_IP_ANY))))

					goto csum_none;

				if (check_csum(cqe, skb, va, dev->features))

					goto csum_none;