Commit a955358d authored Apr 06, 2018 by Rodrigo Rivas Costa Committed by Jiri Kosina Apr 09, 2018

HID: hidraw: Fix crash on HIDIOCGFEATURE with a destroyed device



Doing `ioctl(HIDIOCGFEATURE)` in a tight loop on a hidraw device
and then disconnecting the device, or unloading the driver, can
cause a NULL pointer dereference.

When a hidraw device is destroyed it sets 0 to `dev->exist`.
Most functions check 'dev->exist' before doing its work, but
`hidraw_get_report()` was missing that check.

Cc: stable@vger.kernel.org
Signed-off-by: Rodrigo Rivas Costa <rodrigorivascosta@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 2e210bbb

drivers/hid/hidraw.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -192,6 +192,11 @@ static ssize_t hidraw_get_report(struct file file, char __user buffer, size_t
		int ret = 0, len;
		unsigned char report_number;

		if (!hidraw_table[minor] \|\| !hidraw_table[minor]->exist) {
		ret = -ENODEV;
		goto out;
		}

		dev = hidraw_table[minor]->hid;

		if (!dev->ll_driver->raw_request) {