Commit a945da61 authored Oct 31, 2020 by Zhang Qilong Committed by Greg Kroah-Hartman Nov 18, 2020

vfio: platform: fix reference leak in vfio_platform_open



[ Upstream commit bb742ad01961a3b9d1f9d19375487b879668b6b2 ]

pm_runtime_get_sync() will increment pm usage counter even it
failed. Forgetting to call pm_runtime_put will result in
reference leak in vfio_platform_open, so we should fix it.

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Acked-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2343665e

drivers/vfio/platform/vfio_platform_common.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -273,7 +273,7 @@ static int vfio_platform_open(void *device_data)

		ret = pm_runtime_get_sync(vdev->device);
		if (ret < 0)
		goto err_pm;
		goto err_rst;

		ret = vfio_platform_call_reset(vdev, &extra_dbg);
		if (ret && vdev->reset_required) {
		@@ -290,7 +290,6 @@ static int vfio_platform_open(void *device_data)

		err_rst:
		pm_runtime_put(vdev->device);
		err_pm:
		vfio_platform_irq_cleanup(vdev);
		err_irq:
		vfio_platform_regions_cleanup(vdev);