Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a89f4f1e authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: sym53c8xx: remove some redundant variables 



Variables scriptb0 and dp_sgmin are being assigned but are never used
hence they are redundant and can be removed.

Cleans up clang warnings:
warning: variable 'scriptb0' set but not used [-Wunused-but-set-variable]
warning: variable 'dp_sgmin' set but not used [-Wunused-but-set-variable]

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 46a75118

drivers/scsi/sym53c8xx_2/sym_fw.c

+0 −4
Original line number Diff line number Diff line
@@ -295,10 +295,8 @@ static void 
sym_fw1_setup(struct sym_hcb *np, struct sym_fw *fw)

{

	struct sym_fw1a_scr *scripta0;

	struct sym_fw1b_scr *scriptb0;



	scripta0 = (struct sym_fw1a_scr *) np->scripta0;

	scriptb0 = (struct sym_fw1b_scr *) np->scriptb0;



	/*

	 *  Fill variable parts in scripts.
@@ -319,10 +317,8 @@ static void 
sym_fw2_setup(struct sym_hcb *np, struct sym_fw *fw)

{

	struct sym_fw2a_scr *scripta0;

	struct sym_fw2b_scr *scriptb0;



	scripta0 = (struct sym_fw2a_scr *) np->scripta0;

	scriptb0 = (struct sym_fw2b_scr *) np->scriptb0;



	/*

	 *  Fill variable parts in scripts.

drivers/scsi/sym53c8xx_2/sym_hipd.c

+1 −2
Original line number Diff line number Diff line
@@ -3855,7 +3855,7 @@ static void sym_modify_dp(struct sym_hcb *np, struct sym_tcb *tp, struct sym_ccb 


int sym_compute_residual(struct sym_hcb *np, struct sym_ccb *cp)

{

	int dp_sg, dp_sgmin, resid = 0;

	int dp_sg, resid = 0;

	int dp_ofs = 0;



	/*
@@ -3902,7 +3902,6 @@ int sym_compute_residual(struct sym_hcb *np, struct sym_ccb *cp) 
	 *  We are now full comfortable in the computation 

	 *  of the data residual (2's complement).

	 */

	dp_sgmin = SYM_CONF_MAX_SG - cp->segments;

	resid = -cp->ext_ofs;

	for (dp_sg = cp->ext_sg; dp_sg < SYM_CONF_MAX_SG; ++dp_sg) {

		u_int tmp = scr_to_cpu(cp->phys.data[dp_sg].size);