Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a86f2551 authored by Michał Mirosław's avatar Michał Mirosław Committed by Gerd Hoffmann
Browse files

virtgpu: remove redundant task_comm copying 



Remove redundant task name copying because:

1. task->comm is already NUL-terminated
2. virtio_gpu_context_create() trims passed dbgname anyway

Signed-off-by: default avatarMichał Mirosław <mirq-linux@rere.qmqm.pl>
Link: http://patchwork.freedesktop.org/patch/msgid/588612bbc672e8b598e10f79fcbc041122e844ba.1504202471.git.mirq-linux@rere.qmqm.pl


Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 4013e44f

drivers/gpu/drm/virtio/virtgpu_kms.c

+2 −4
Original line number Diff line number Diff line
@@ -272,20 +272,18 @@ int virtio_gpu_driver_open(struct drm_device *dev, struct drm_file *file) 
	struct virtio_gpu_device *vgdev = dev->dev_private;

	struct virtio_gpu_fpriv *vfpriv;

	uint32_t id;

	char dbgname[64], tmpname[TASK_COMM_LEN];

	char dbgname[TASK_COMM_LEN];



	/* can't create contexts without 3d renderer */

	if (!vgdev->has_virgl_3d)

		return 0;



	get_task_comm(tmpname, current);

	snprintf(dbgname, sizeof(dbgname), "%s", tmpname);

	dbgname[63] = 0;

	/* allocate a virt GPU context for this opener */

	vfpriv = kzalloc(sizeof(*vfpriv), GFP_KERNEL);

	if (!vfpriv)

		return -ENOMEM;



	get_task_comm(dbgname, current);

	virtio_gpu_context_create(vgdev, strlen(dbgname), dbgname, &id);



	vfpriv->ctx_id = id;