Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a867bb28 authored by Steven Whitehouse's avatar Steven Whitehouse
Browse files

[GFS2] Fix incorrect error path in prepare_write() 



The error path in prepare_write() was incorrect in the (very rare) event
that the transaction fails to start. The following prevents a NULL
pointer dereference,

Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
parent 6eefaf61

fs/gfs2/ops_address.c

+2 −1
Original line number Diff line number Diff line
@@ -416,7 +416,7 @@ static int gfs2_prepare_write(struct file *file, struct page *page, 


	error = gfs2_trans_begin(sdp, rblocks, 0);

	if (error)

		goto out;

		goto out_trans_fail;



	if (gfs2_is_stuffed(ip)) {

		if (end > sdp->sd_sb.sb_bsize - sizeof(struct gfs2_dinode)) {
@@ -434,6 +434,7 @@ static int gfs2_prepare_write(struct file *file, struct page *page, 
out:

	if (error) {

		gfs2_trans_end(sdp);

out_trans_fail:

		if (alloc_required) {

			gfs2_inplace_release(ip);

out_qunlock: