Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a8373f1a authored by Lendacky, Thomas's avatar Lendacky, Thomas Committed by David S. Miller
Browse files

amd-xgbe: Add support for the netdev Tx watchdog 



Add support to be able to detect a hung Tx task by adding the netdev
ndo_tx_timeout function callback. Do not set the watchdog_timeo value
so as to use the system default time (currently 5 seconds).

Signed-off-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b876382b

drivers/net/ethernet/amd/xgbe/xgbe-drv.c

+9 −0
Original line number Diff line number Diff line
@@ -1600,6 +1600,14 @@ static int xgbe_change_mtu(struct net_device *netdev, int mtu) 
	return 0;

}



static void xgbe_tx_timeout(struct net_device *netdev)

{

	struct xgbe_prv_data *pdata = netdev_priv(netdev);



	netdev_warn(netdev, "tx timeout, device restarting\n");

	schedule_work(&pdata->restart_work);

}



static struct rtnl_link_stats64 *xgbe_get_stats64(struct net_device *netdev,

						  struct rtnl_link_stats64 *s)

{
@@ -1764,6 +1772,7 @@ static const struct net_device_ops xgbe_netdev_ops = { 
	.ndo_validate_addr	= eth_validate_addr,

	.ndo_do_ioctl		= xgbe_ioctl,

	.ndo_change_mtu		= xgbe_change_mtu,

	.ndo_tx_timeout		= xgbe_tx_timeout,

	.ndo_get_stats64	= xgbe_get_stats64,

	.ndo_vlan_rx_add_vid	= xgbe_vlan_rx_add_vid,

	.ndo_vlan_rx_kill_vid	= xgbe_vlan_rx_kill_vid,

drivers/net/ethernet/amd/xgbe/xgbe-main.c

+3 −0
Original line number Diff line number Diff line
@@ -491,6 +491,9 @@ static int xgbe_probe(struct platform_device *pdev) 


	netdev->priv_flags |= IFF_UNICAST_FLT;



	/* Use default watchdog timeout */

	netdev->watchdog_timeo = 0;



	xgbe_init_rx_coalesce(pdata);

	xgbe_init_tx_coalesce(pdata);