Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a82dadbc authored by Ram Amrani's avatar Ram Amrani Committed by David S. Miller
Browse files

qed: Correct doorbell configuration for !4Kb pages 



When configuring the doorbell DPI address, driver aligns the start
address to 4KB [HW-pages] instead of host PAGE_SIZE.
As a result, RoCE applications might receive addresses which are
unaligned to pages [when PAGE_SIZE > 4KB], which is a security risk.

Fixes: 51ff1725 ("qed: Add support for RoCE hw init")
Signed-off-by: default avatarRam Amrani <Ram.Amrani@cavium.com>
Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c9f0523b

drivers/net/ethernet/qlogic/qed/qed_dev.c

+1 −1
Original line number Diff line number Diff line
@@ -1370,7 +1370,7 @@ qed_hw_init_pf_doorbell_bar(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt) 
						   NULL) +

		       qed_cxt_get_proto_cid_count(p_hwfn, PROTOCOLID_ETH,

						   NULL);

	norm_regsize = roundup(QED_PF_DEMS_SIZE * non_pwm_conn, 4096);

	norm_regsize = roundup(QED_PF_DEMS_SIZE * non_pwm_conn, PAGE_SIZE);

	min_addr_reg1 = norm_regsize / 4096;

	pwm_regsize = db_bar_size - norm_regsize;