Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a724b436 authored by Stefan Behrens's avatar Stefan Behrens Committed by Chris Mason
Browse files

Btrfs: add the missing mutex unlock in write_all_supers() 



The BUG() was replaced by btrfs_error() and return -EIO with the
patch "get rid of one BUG() in write_all_supers()", but the missing
mutex_unlock() was overlooked.

The 0-DAY kernel build service from Intel reported the missing
unlock which was found by the coccinelle tool:

    fs/btrfs/disk-io.c:3422:2-8: preceding lock on line 3374

Signed-off-by: default avatarStefan Behrens <sbehrens@giantdisaster.de>
Signed-off-by: default avatarJosef Bacik <jbacik@fusionio.com>
Signed-off-by: default avatarChris Mason <chris.mason@fusionio.com>
parent f4ab9ea7

fs/btrfs/disk-io.c

+1 −0
Original line number Diff line number Diff line
@@ -3416,6 +3416,7 @@ static int write_all_supers(struct btrfs_root *root, int max_mirrors) 
	if (total_errors > max_errors) {

		printk(KERN_ERR "btrfs: %d errors while writing supers\n",

		       total_errors);

		mutex_unlock(&root->fs_info->fs_devices->device_list_mutex);



		/* FUA is masked off if unsupported and can't be the reason */

		btrfs_error(root->fs_info, -EIO,