Commit a717bbd1 authored May 28, 2020 by Qiushi Wu Committed by Sasha Levin Jun 30, 2020

efi/esrt: Fix reference count leak in esre_create_sysfs_entry.



[ Upstream commit 4ddf4739be6e375116c375f0a68bf3893ffcee21 ]

kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Previous
commit "b8eb718348b8" fixed a similar problem.

Fixes: 0bb54905 ("efi: Add esrt support")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Link: https://lore.kernel.org/r/20200528183804.4497-1-wu000273@umn.edu


Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 932a5808

drivers/firmware/efi/esrt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -180,7 +180,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num)
		rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL,
		"entry%d", entry_num);
		if (rc) {
		kfree(entry);
		kobject_put(&entry->kobj);
		return rc;
		}
		}