Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Snippets Groups Projects
Commit a6fe6708 authored by Bjørn Mork's avatar Bjørn Mork Committed by David S. Miller
Browse files

net: cdc_ncm: no not set tx_max higher than the device supports


There are MBIM devices out there reporting

  dwNtbInMaxSize=2048 dwNtbOutMaxSize=2048

and since the spec require a datagram max size of at least
2048, this means that a full sized datagram will never fit.

Still, sending larger NTBs than the device supports is not
going to help.  We do not have any other options than either
 a) refusing to bindi, or
 b) respect the insanely low value.

Alternative b will at least make these devices work, so go
for it.

Cc: Alexey Orishko <alexey.orishko@gmail.com>
Signed-off-by: default avatarBjørn Mork <bjorn@mork.no>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 296e81f8
Branches
No related tags found
No related merge requests found
...@@ -159,8 +159,7 @@ static u8 cdc_ncm_setup(struct usbnet *dev) ...@@ -159,8 +159,7 @@ static u8 cdc_ncm_setup(struct usbnet *dev)
} }
/* verify maximum size of transmitted NTB in bytes */ /* verify maximum size of transmitted NTB in bytes */
if ((ctx->tx_max < (CDC_NCM_MIN_HDR_SIZE + ctx->max_datagram_size)) || if (ctx->tx_max > CDC_NCM_NTB_MAX_SIZE_TX) {
(ctx->tx_max > CDC_NCM_NTB_MAX_SIZE_TX)) {
dev_dbg(&dev->intf->dev, "Using default maximum transmit length=%d\n", dev_dbg(&dev->intf->dev, "Using default maximum transmit length=%d\n",
CDC_NCM_NTB_MAX_SIZE_TX); CDC_NCM_NTB_MAX_SIZE_TX);
ctx->tx_max = CDC_NCM_NTB_MAX_SIZE_TX; ctx->tx_max = CDC_NCM_NTB_MAX_SIZE_TX;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment