Commit a6da48ca authored Jul 16, 2018 by Junwei Zhang Committed by Alex Deucher Jul 16, 2018

drm/scheduler: add NULL pointer check for run queue (v2)



To check rq pointer before adding entity into it.
That avoids NULL pointer access in some case.

v2: move the check to caller

Suggested-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 964d0fbf

drivers/gpu/drm/scheduler/gpu_scheduler.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -547,6 +547,11 @@ void drm_sched_entity_push_job(struct drm_sched_job *sched_job,
		if (first) {
		/* Add the entity to the run queue */
		spin_lock(&entity->rq_lock);
		if (!entity->rq) {
		DRM_ERROR("Trying to push to a killed entity\n");
		spin_unlock(&entity->rq_lock);
		return;
		}
		drm_sched_rq_add_entity(entity->rq, entity);
		spin_unlock(&entity->rq_lock);
		drm_sched_wakeup(sched);