Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a61d5ce9 authored by Or Gerlitz's avatar Or Gerlitz Committed by Saeed Mahameed
Browse files

net/mlx5: Fix static checker warnings 



For some reason, sparse doesn't like using an expression of type (!x)
with a bitwise | and &.  In order to mitigate that, we use a local variable.

This removes the following sparse complaints on the core driver
(and similar ones on the IB driver too):

drivers/net/ethernet/mellanox/mlx5/core/srq.c:83:9: warning: dubious: !x & y
drivers/net/ethernet/mellanox/mlx5/core/srq.c:96:9: warning: dubious: !x & y
drivers/net/ethernet/mellanox/mlx5/core/port.c:59:9: warning: dubious: !x & y
drivers/net/ethernet/mellanox/mlx5/core/vport.c:561:9: warning: dubious: !x & y

Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: default avatarMatan Barak <matanb@mellanox.com>
Reported-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent bd092ad1

include/linux/mlx5/device.h

+2 −1
Original line number Diff line number Diff line
@@ -67,10 +67,11 @@ 


/* insert a value to a struct */

#define MLX5_SET(typ, p, fld, v) do { \

	u32 _v = v; \

	BUILD_BUG_ON(__mlx5_st_sz_bits(typ) % 32);             \

	*((__be32 *)(p) + __mlx5_dw_off(typ, fld)) = \

	cpu_to_be32((be32_to_cpu(*((__be32 *)(p) + __mlx5_dw_off(typ, fld))) & \

		     (~__mlx5_dw_mask(typ, fld))) | (((v) & __mlx5_mask(typ, fld)) \

		     (~__mlx5_dw_mask(typ, fld))) | (((_v) & __mlx5_mask(typ, fld)) \

		     << __mlx5_dw_bit_off(typ, fld))); \

} while (0)