Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a5a7a060 authored by Jaegeuk Kim's avatar Jaegeuk Kim
Browse files

f2fs: give some messages for inline_xattr_size 



This patch adds some kernel messages when user sets wrong inline_xattr_size.

Fixes: 500e0b28ecd3 ("f2fs: fix to check inline_xattr_size boundary correctly")
Signed-off-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent ea695729

fs/f2fs/super.c

+11 −6
Original line number Diff line number Diff line
@@ -821,6 +821,8 @@ static int parse_options(struct super_block *sb, char *options) 
	}



	if (test_opt(sbi, INLINE_XATTR_SIZE)) {

		int min_size, max_size;



		if (!f2fs_sb_has_extra_attr(sbi) ||

			!f2fs_sb_has_flexible_inline_xattr(sbi)) {

			f2fs_msg(sb, KERN_ERR,
@@ -834,15 +836,18 @@ static int parse_options(struct super_block *sb, char *options) 
					"set with inline_xattr option");

			return -EINVAL;

		}

		if (F2FS_OPTION(sbi).inline_xattr_size <

			sizeof(struct f2fs_xattr_header) / sizeof(__le32) ||

			F2FS_OPTION(sbi).inline_xattr_size >

			DEF_ADDRS_PER_INODE -



		min_size = sizeof(struct f2fs_xattr_header) / sizeof(__le32);

		max_size = DEF_ADDRS_PER_INODE -

			F2FS_TOTAL_EXTRA_ATTR_SIZE / sizeof(__le32) -

			DEF_INLINE_RESERVED_SIZE -

			MIN_INLINE_DENTRY_SIZE / sizeof(__le32)) {

			MIN_INLINE_DENTRY_SIZE / sizeof(__le32);



		if (F2FS_OPTION(sbi).inline_xattr_size < min_size ||

				F2FS_OPTION(sbi).inline_xattr_size > max_size) {

			f2fs_msg(sb, KERN_ERR,

					"inline xattr size is out of range");

				"inline xattr size is out of range: %d ~ %d",

				min_size, max_size);

			return -EINVAL;

		}

	}