Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a589e211 authored by Jan Kiszka's avatar Jan Kiszka Committed by Linus Walleij
Browse files

gpio: exar: Use correct property prefix and document bindings 



The device-specific property should be prefixed with the vendor name,
not "linux,", as Linus Walleij pointed out. Change this and document the
bindings of this platform device.

We didn't ship the old binding in a release yet. So we can still change
it without breaking an official API.

Fixes: 380b1e2f ("gpio-exar/8250-exar: Make set of exported GPIOs configurable")
Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
Acked-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent cc9269f8

Documentation/devicetree/bindings/gpio/gpio-exar.txt

0 → 100644
+5 −0
Original line number Diff line number Diff line 
Exportable MPIO interface of Exar UART chips



Required properties of the device:

 - exar,first-pin: first exportable pins (0..15)

 - ngpios: number of exportable pins (1..16)

drivers/gpio/gpio-exar.c

+1 −1
Original line number Diff line number Diff line
@@ -132,7 +132,7 @@ static int gpio_exar_probe(struct platform_device *pdev) 
	if (!p)

		return -ENOMEM;



	ret = device_property_read_u32(&pdev->dev, "linux,first-pin",

	ret = device_property_read_u32(&pdev->dev, "exar,first-pin",

				       &first_pin);

	if (ret)

		return ret;

drivers/tty/serial/8250/8250_exar.c

+2 −2
Original line number Diff line number Diff line
@@ -261,7 +261,7 @@ __xr17v35x_register_gpio(struct pci_dev *pcidev, 
}



static const struct property_entry exar_gpio_properties[] = {

	PROPERTY_ENTRY_U32("linux,first-pin", 0),

	PROPERTY_ENTRY_U32("exar,first-pin", 0),

	PROPERTY_ENTRY_U32("ngpios", 16),

	{ }

};
@@ -326,7 +326,7 @@ static int iot2040_rs485_config(struct uart_port *port, 
}



static const struct property_entry iot2040_gpio_properties[] = {

	PROPERTY_ENTRY_U32("linux,first-pin", 10),

	PROPERTY_ENTRY_U32("exar,first-pin", 10),

	PROPERTY_ENTRY_U32("ngpios", 1),

	{ }

};