Commit a568d1d2 authored Oct 21, 2008 by Tejun Heo Committed by Jeff Garzik Oct 22, 2008

libata-eh: fix slave link EH action mask handling



Slave link action mask is transferred to master link and all the EH
actions are taken by the master link.  ata_eh_about_to_do() and
ata_eh_done() are called with ATA_EH_ALL_ACTIONS to clear the slave
link actions during transfer.  This always sets ATA_PFLAG_RECOVERED
flag causing spurious "EH complete" messages.

Don't set ATA_PFLAG_RECOVERED for slave link actions.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent 848e4c68

drivers/ata/libata-eh.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1206,7 +1206,10 @@ void ata_eh_about_to_do(struct ata_link link, struct ata_device dev,

		ata_eh_clear_action(link, dev, ehi, action);

		if (!(ehc->i.flags & ATA_EHI_QUIET))
		/* About to take EH action, set RECOVERED. Ignore actions on
		* slave links as master will do them again.
		*/
		if (!(ehc->i.flags & ATA_EHI_QUIET) && link != ap->slave_link)
		ap->pflags \|= ATA_PFLAG_RECOVERED;

		spin_unlock_irqrestore(ap->lock, flags);