Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a50abf48 authored by Bob Moore's avatar Bob Moore Committed by Rafael J. Wysocki
Browse files

ACPICA: Return error if DerefOf resolves to a null package element. 

Disallow the dereference of a reference (via index) to an uninitialized
package element. Provides compatibility with other ACPI
implementations. ACPICA BZ 1003.

References: https://bugs.acpica.org/show_bug.cgi?id=431


Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 1d82980c

drivers/acpi/acpica/exoparg1.c

+10 −3
Original line number Diff line number Diff line
@@ -962,10 +962,17 @@ acpi_status acpi_ex_opcode_1A_0T_1R(struct acpi_walk_state *walk_state) 
					 */

					return_desc =

					    *(operand[0]->reference.where);

					if (return_desc) {

						acpi_ut_add_reference

						    (return_desc);

					if (!return_desc) {

						/*

						 * Element is NULL, do not allow the dereference.

						 * This provides compatibility with other ACPI

						 * implementations.

						 */

						return_ACPI_STATUS

						    (AE_AML_UNINITIALIZED_ELEMENT);

					}



					acpi_ut_add_reference(return_desc);

					break;



				default: