Commit a4bd8520 authored Apr 14, 2016 by Dan Carpenter Committed by James Bottomley Apr 30, 2016

scsi_dh_alua: uninitialized variable in alua_rtpg()



It's possible to use "err" without initializing it.  If it happens to be
a 2 which is SCSI_DH_RETRY then that could cause a bug.  Bart Van Assche
pointed out that we should probably re-initialize it for every iteration
through the retry loop.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hannes Reinicke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: James Bottomley <jejb@linux.vnet.ibm.com>

parent c3b46c73

drivers/scsi/device_handler/scsi_dh_alua.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -532,6 +532,7 @@ static int alua_rtpg(struct scsi_device sdev, struct alua_port_group pg)
		return SCSI_DH_DEV_TEMP_BUSY;

		retry:
		err = 0;
		retval = submit_rtpg(sdev, buff, bufflen, &sense_hdr, pg->flags);

		if (retval) {