Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4210141 authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf report: Use pr_*() functions where applicable 



There're some places printing messages to stdout/err directly.

It should be converted to use proper error printing functions instead.

Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1387516278-17024-2-git-send-email-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent cc22e575

tools/perf/builtin-report.c

+4 −4
Original line number Diff line number Diff line
@@ -242,7 +242,7 @@ static int process_sample_event(struct perf_tool *tool, 
	int ret;



	if (perf_event__preprocess_sample(event, machine, &al, sample) < 0) {

		fprintf(stderr, "problem processing %d event, skipping it.\n",

		pr_debug("problem processing %d event, skipping it.\n",

			 event->header.type);

		return -1;

	}
@@ -637,7 +637,7 @@ parse_callchain_opt(const struct option *opt, const char *arg, int unset) 
		return -1;

setup:

	if (callchain_register_param(&callchain_param) < 0) {

		fprintf(stderr, "Can't register callchain params\n");

		pr_err("Can't register callchain params\n");

		return -1;

	}

	return 0;
@@ -859,7 +859,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused) 
	}

	if (report.mem_mode) {

		if (sort__mode == SORT_MODE__BRANCH) {

			fprintf(stderr, "branch and mem mode incompatible\n");

			pr_err("branch and mem mode incompatible\n");

			goto error;

		}

		sort__mode = SORT_MODE__MEMORY;