Commit a4007041 authored Mar 04, 2013 by Sachin Kamat Committed by Felipe Balbi Mar 04, 2013

usb: phy: samsung: Convert to devm_ioremap_resource()



Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.

Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent 1dd03d8a

drivers/usb/phy/samsung-usbphy.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -787,11 +787,9 @@ static int samsung_usbphy_probe(struct platform_device *pdev)
		return -ENODEV;
		}

		phy_base = devm_request_and_ioremap(dev, phy_mem);
		if (!phy_base) {
		dev_err(dev, "%s: register mapping failed\n", __func__);
		return -ENXIO;
		}
		phy_base = devm_ioremap_resource(dev, phy_mem);
		if (IS_ERR(phy_base))
		return PTR_ERR(phy_base);

		sphy = devm_kzalloc(dev, sizeof(*sphy), GFP_KERNEL);
		if (!sphy)