Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a3c4c580 authored by Li Hong's avatar Li Hong Committed by Borislav Petkov
Browse files

amd64_edac: fix a wrong goto clause in amd64_edac.c 



In amd64_edac_init(void) in amd64_edac.c, cache_k8_northbridges() is
called before pci_register_driver. If it fails, should exit with err
directly.

Signed-off-by: default avatarLi Hong <lihong.hi@gmail.com>
Acked-by: default avatarDoug Thompson <dougthompson@xmission.com>
Signed-off-by: default avatarBorislav Petkov <borislav.petkov@amd.com>
parent b419148e

drivers/edac/amd64_edac.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -3163,7 +3163,7 @@ static int __init amd64_edac_init(void) 
	opstate_init();

	opstate_init();





	if (cache_k8_northbridges() < 0)

	if (cache_k8_northbridges() < 0)

		goto err_exit;

		return err;





	err = pci_register_driver(&amd64_pci_driver);

	err = pci_register_driver(&amd64_pci_driver);

	if (err)

	if (err)
@@ -3189,8 +3189,6 @@ static int __init amd64_edac_init(void) 




err_2nd_stage:

err_2nd_stage:

	debugf0("2nd stage failed\n");

	debugf0("2nd stage failed\n");



err_exit:

	pci_unregister_driver(&amd64_pci_driver);

	pci_unregister_driver(&amd64_pci_driver);





	return err;

	return err;