Commit a3a9a59d authored Jun 24, 2016 by Michal Hocko Committed by Linus Torvalds Jun 24, 2016

x86: get rid of superfluous __GFP_REPEAT

__GFP_REPEAT has a rather weak semantic but since it has been introduced
around 2.6.12 it has been ignored for low order allocations.

PGALLOC_GFP uses __GFP_REPEAT but none of the allocation which uses this
flag is for more than order-0.  This means that this flag has never been
actually useful here because it has always been used only for
PAGE_ALLOC_COSTLY requests.

Link: http://lkml.kernel.org/r/1464599699-30131-3-git-send-email-mhocko@kernel.org


Signed-off-by: Michal Hocko <mhocko@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 32d6bd90

arch/x86/kernel/espfix_64.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -57,7 +57,7 @@
		# error "Need more than one PGD for the ESPFIX hack"
		#endif

		#define PGALLOC_GFP (GFP_KERNEL \| __GFP_NOTRACK \| __GFP_REPEAT \| __GFP_ZERO)
		#define PGALLOC_GFP (GFP_KERNEL \| __GFP_NOTRACK \| __GFP_ZERO)

		/* This contains the bottom address of the espfix stack */
		DEFINE_PER_CPU_READ_MOSTLY(unsigned long, espfix_stack);

arch/x86/mm/pgtable.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6,7 +6,7 @@
		#include <asm/fixmap.h>
		#include <asm/mtrr.h>

		#define PGALLOC_GFP GFP_KERNEL \| __GFP_NOTRACK \| __GFP_REPEAT \| __GFP_ZERO
		#define PGALLOC_GFP GFP_KERNEL \| __GFP_NOTRACK \| __GFP_ZERO

		#ifdef CONFIG_HIGHPTE
		#define PGALLOC_USER_GFP __GFP_HIGHMEM