Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a39f2fe7 authored by Jan Kiszka's avatar Jan Kiszka
Browse files

gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards 



Commtech adapters need the MPIOs for internal purposes, and the
gpio-exar driver already refused to pick them up. But there is actually
no point in even creating the underlying platform device.

Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6697f1f8

drivers/gpio/gpio-exar.c

+0 −3
Original line number Diff line number Diff line
@@ -124,9 +124,6 @@ static int gpio_exar_probe(struct platform_device *pdev) 
	void __iomem *p;

	int index, ret;



	if (pcidev->vendor != PCI_VENDOR_ID_EXAR)

		return -ENODEV;



	/*

	 * Map the pci device to get the register addresses.

	 * We will need to read and write those registers to control

drivers/tty/serial/8250/8250_exar.c

+3 −1
Original line number Diff line number Diff line
@@ -239,7 +239,9 @@ pci_xr17v35x_setup(struct exar8250 *priv, struct pci_dev *pcidev, 
		/* Setup Multipurpose Input/Output pins. */

		setup_gpio(p);



		port->port.private_data = xr17v35x_register_gpio(pcidev);

		if (pcidev->vendor == PCI_VENDOR_ID_EXAR)

			port->port.private_data =

				xr17v35x_register_gpio(pcidev);

	}



	return 0;