Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a3564d2b authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Daniel Vetter
Browse files

drm/i915/bdw: Don't use forcewake needlessly 



Not all registers need forcewake even if they're not shadowed.
Add the missing check to gen8_writeX() to avoid needless forcewake
usage when writing eg. display registers.

v2: Use straight up <0x40000 check instead of NEEDS_FORCE_WAKE()

Reviewed-by: default avatarBen Widawsky <ben@bwidawsk.net>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 97058870

drivers/gpu/drm/i915/intel_uncore.c

+1 −1
Original line number Diff line number Diff line
@@ -634,7 +634,7 @@ static bool is_gen8_shadowed(struct drm_i915_private *dev_priv, u32 reg) 
#define __gen8_write(x) \

static void \

gen8_write##x(struct drm_i915_private *dev_priv, off_t reg, u##x val, bool trace) { \

	bool __needs_put = !is_gen8_shadowed(dev_priv, reg); \

	bool __needs_put = reg < 0x40000 && !is_gen8_shadowed(dev_priv, reg); \

	REG_WRITE_HEADER; \

	if (__needs_put) { \

		dev_priv->uncore.funcs.force_wake_get(dev_priv, \