Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a328512d authored by Benoit Taine's avatar Benoit Taine Committed by Greg Kroah-Hartman
Browse files

USB: storage: ene_ub6250: Use kmemdup instead of kmalloc + memcpy 



This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci

Signed-off-by: default avatarBenoit Taine <benoit.taine@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a7683eb3

drivers/usb/storage/ene_ub6250.c

+1 −2
Original line number Diff line number Diff line
@@ -1928,11 +1928,10 @@ static int ene_load_bincode(struct us_data *us, unsigned char flag) 
		usb_stor_dbg(us, "load firmware %s failed\n", fw_name);

		goto nofw;

	}

	buf = kmalloc(sd_fw->size, GFP_KERNEL);

	buf = kmemdup(sd_fw->data, sd_fw->size, GFP_KERNEL);

	if (buf == NULL)

		goto nofw;



	memcpy(buf, sd_fw->data, sd_fw->size);

	memset(bcb, 0, sizeof(struct bulk_cb_wrap));

	bcb->Signature = cpu_to_le32(US_BULK_CB_SIGN);

	bcb->DataTransferLength = sd_fw->size;