Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a31267c3 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by John W. Linville
Browse files

rtl8187: fix use after free on failure path in rtl8187_probe() 



If allocation of io_dmabuf fails, rtl8187_probe() calls usb_put_dev(udev)
while usb_get_dev(udev) is not called yet. As a result refcnt is decremented
incorrectly and usb_dev can be used after memory deallocation.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 6cea5f21

drivers/net/wireless/rtl818x/rtl8187/dev.c

+2 −2
Original line number Diff line number Diff line
@@ -1636,10 +1636,10 @@ static int rtl8187_probe(struct usb_interface *intf, 


 err_free_dmabuf:

	kfree(priv->io_dmabuf);

 err_free_dev:

	ieee80211_free_hw(dev);

	usb_set_intfdata(intf, NULL);

	usb_put_dev(udev);

 err_free_dev:

	ieee80211_free_hw(dev);

	return err;

}