Commit a2d713c0 authored Apr 23, 2021 by Krzysztof Kozlowski Committed by Greg Kroah-Hartman Jul 20, 2021

memory: atmel-ebi: add missing of_node_put for loop iteration



[ Upstream commit 907c5bbb514a4676160e79764522fff56ce3448e ]

Early exits from for_each_available_child_of_node() should decrement the
node reference counter.  Reported by Coccinelle:

  drivers/memory/atmel-ebi.c:593:1-33: WARNING:
    Function "for_each_available_child_of_node" should have of_node_put() before return around line 604.

Fixes: 6a4ec4cd ("memory: add Atmel EBI (External Bus Interface) driver")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210423101815.119341-2-krzysztof.kozlowski@canonical.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2408a5e8

drivers/memory/atmel-ebi.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -579,10 +579,12 @@ static int atmel_ebi_probe(struct platform_device *pdev)
		child);

		ret = atmel_ebi_dev_disable(ebi, child);
		if (ret)
		if (ret) {
		of_node_put(child);
		return ret;
		}
		}
		}

		return of_platform_populate(np, NULL, NULL, dev);
		}