Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a25cdc0d authored by Arnd Bergmann's avatar Arnd Bergmann Committed by David S. Miller
Browse files

net: mediatek: remove incorrect dma_mask assignment 



Device drivers should not mess with the DMA mask directly,
but instead call dma_set_mask() etc if needed.

In case of the mtk_eth_soc driver, the mask already gets set
correctly when the device is created, and setting it again
is against the documented API.

This removes the incorrect setting.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6aab1a62

drivers/net/ethernet/mediatek/mtk_eth_soc.c

+0 −3
Original line number Diff line number Diff line
@@ -1676,9 +1676,6 @@ static int mtk_probe(struct platform_device *pdev) 
	struct mtk_eth *eth;

	int err;



	pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);

	pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;



	device_reset(&pdev->dev);



	match = of_match_device(of_mtk_match, &pdev->dev);