Commit a24e7917 authored Jan 11, 2018 by Wei Yongjun Committed by Nicholas Bellinger Jan 12, 2018

tcmu: fix error return code in tcmu_configure_device()



Fix to return error code -ENOMEM from the kzalloc() error handling
case instead of 0, as done elsewhere in this function.

Fixes: 80eb8761 ("tcmu: allow max block and global max blocks to be settable")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 88cf1073

drivers/target/target_core_user.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1675,8 +1675,10 @@ static int tcmu_configure_device(struct se_device *dev)

		udev->data_bitmap = kzalloc(BITS_TO_LONGS(udev->max_blocks) *
		sizeof(unsigned long), GFP_KERNEL);
		if (!udev->data_bitmap)
		if (!udev->data_bitmap) {
		ret = -ENOMEM;
		goto err_bitmap_alloc;
		}

		udev->mb_addr = vzalloc(CMDR_SIZE);
		if (!udev->mb_addr) {