Commit a24b8c34 authored Jun 13, 2017 by Yazen Ghannam Committed by Ingo Molnar Jun 14, 2017

x86/mce/AMD: Use msr_stat when clearing MCA_STATUS



The value of MCA_STATUS is used as the MSR when clearing MCA_STATUS.

This may cause the following warning:

 unchecked MSR access error: WRMSR to 0x11b (tried to write 0x0000000000000000)
 Call Trace:
  <IRQ>
  smp_threshold_interrupt()
  threshold_interrupt()

Use msr_stat instead which has the MSR address.

Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Fixes: 37d43acf ("x86/mce/AMD: Redo error logging from APIC LVT interrupt handlers")
Link: http://lkml.kernel.org/r/20170613162835.30750-2-bp@alien8.de


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 10b90ee2

arch/x86/kernel/cpu/mcheck/mce_amd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -815,7 +815,7 @@ _log_error_bank(unsigned int bank, u32 msr_stat, u32 msr_addr, u64 misc)

		__log_error(bank, status, addr, misc);

		wrmsrl(status, 0);
		wrmsrl(msr_stat, 0);

		return status & MCI_STATUS_DEFERRED;
		}