Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1d19bd4 authored by Frank Rowand's avatar Frank Rowand Committed by Rob Herring
Browse files

of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove 



A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP,
or an embedded errno.  overlay_notify() incorrectly reports an
error for NOTIFY_OK.

Reported-by: default avatar <atull@kernel.org>
Signed-off-by: default avatarFrank Rowand <frank.rowand@sony.com>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 34ca5d76

drivers/of/overlay.c

+1 −1
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs, 


		ret = blocking_notifier_call_chain(&overlay_notify_chain,

						   action, &nd);

		if (ret == NOTIFY_STOP)

		if (ret == NOTIFY_OK || ret == NOTIFY_STOP)

			return 0;

		if (ret) {

			ret = notifier_to_errno(ret);